Add analyzer/fixer for unnecessary global SuppressMessageAttributes with invalid 'Scope' and/or 'Target'#44287
Merged
6 commits merged intodotnet:masterfrom May 18, 2020
Merged
Conversation
…Scope and/or Target These suppressions are redundant and can be removed. Closes dotnet#44176
mavasani
commented
May 15, 2020
| return true; | ||
| } | ||
|
|
||
| internal enum TargetScope |
Contributor
Author
There was a problem hiding this comment.
@dotnet/roslyn-compiler Only compiler change in the PR is moving this nested internal enum to a separate file, so it can be used by the added analyzer to detect invalid SuppressMessageAttribute target/scope. This new file is linked into the IDE analyzer layer.
jaredpar
approved these changes
May 15, 2020
sharwell
reviewed
May 18, 2020
...yzers/RemoveUnnecessarySuppressions/CSharpRemoveUnnecessarySuppressionsDiagnosticAnalyzer.cs
Show resolved
Hide resolved
src/Analyzers/CSharp/Tests/RemoveUnnecessarySuppressions/RemoveUnnecessarySuppressionsTests.cs
Show resolved
Hide resolved
src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/SuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/SuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/SuppressMessageAttributeState.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/Core/Analyzers/RemoveUnnecessarySuppressions/SuppressMessageAttributeState.cs
Show resolved
Hide resolved
sharwell
suggested changes
May 18, 2020
...Core/CodeFixes/RemoveUnnecessarySuppressions/RemoveUnnecessarySuppressionsCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
...Core/CodeFixes/RemoveUnnecessarySuppressions/RemoveUnnecessarySuppressionsCodeFixProvider.cs
Show resolved
Hide resolved
...Core/CodeFixes/RemoveUnnecessarySuppressions/RemoveUnnecessarySuppressionsCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
May 18, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppressions are greyed out in the IDE as they are redundant and can be removed.
Closes #44176
NOTE: I have moved the xlf file changes to a separate commit to help with review.