Fix up Theory that wasn't actually using the test parameters#44277
Merged
1 commit merged intodotnet:masterfrom May 16, 2020
Merged
Fix up Theory that wasn't actually using the test parameters#442771 commit merged intodotnet:masterfrom
1 commit merged intodotnet:masterfrom
Conversation
Originally there was just the TestSourceFilePathMappingWithDriveLetterOnly test which was a simple fact that only covered one case. It looks like I copied that intending to add a second test, and then converted the second copy to a Theory...and then never updated that properly either nor deleted the original. This puts everything back in order. Fixes dotnet#44224
c6a0ee2 to
d37728c
Compare
mavasani
approved these changes
May 15, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally there was just the TestSourceFilePathMappingWithDriveLetterOnly test which was a simple fact that only covered one case. It looks like I copied that intending to add a second test, and then converted the second copy to a Theory...and then never updated that properly nor deleted the original. This puts everything back in order.
Fixes #44224