Ensure we clear out existing todo comments when a user deletes a file.#44274
Merged
CyrusNajmabadi merged 4 commits intodotnet:masterfrom May 16, 2020
Merged
Ensure we clear out existing todo comments when a user deletes a file.#44274CyrusNajmabadi merged 4 commits intodotnet:masterfrom
CyrusNajmabadi merged 4 commits intodotnet:masterfrom
Conversation
sharwell
reviewed
May 14, 2020
src/VisualStudio/Core/Def/Implementation/TodoComments/VisualStudioTodoCommentsService.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
May 15, 2020
| new object[] { documentId }, | ||
| nameof(ITodoCommentsListener.ReportTodoCommentDataAsync), | ||
| new object[] { documentId, Array.Empty<TodoCommentData>() }, | ||
| cancellationToken); |
Contributor
Author
There was a problem hiding this comment.
@uniqueiniquity Once this goes in, TS will be able to do the same. To represent a document being deleted, just notify us that the set of comments for it went to 'empty'. we'll clean things out in memory and will update the task list.
sharwell
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44062
Working on an integration test now.