Remove trailing space from BoundDecisionDagNode#43982
Merged
sharwell merged 1 commit intodotnet:masterfrom May 5, 2020
Merged
Conversation
cston
reviewed
May 5, 2020
| { | ||
| this.Visit(node.RootNode); | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
Are these code changes the result of removing the space? If so, we should throw an exception in the BoundNode generator if the name fields contain spaces.
Member
There was a problem hiding this comment.
Agreed. However, this change is harmless as we don't use the visitor mechanism for decision dags or its nodes.
Contributor
Author
There was a problem hiding this comment.
Are these code changes the result of removing the space?
Yes
Contributor
gafter
approved these changes
May 5, 2020
cston
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed this while working on formatter performance investigations.