Merged
Conversation
dibarbet
approved these changes
May 5, 2020
Contributor
Author
|
Thanks! |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These value don't dynamically go back to the FS to get updated info. So, for example, properties like
.Existswill continue reporting the same value every time they're queried (even if the underlying may or may not be there).This affected the nuget index in a minor way:
THis would repeat once a day until vs was restarted. So, overall not too bad. At worst, one extra download a day. And only as long as you were in the original VS sessoin and never closed it. But still not desirable.
We now properly re-acquire the FileInfo value when starting the update process to make sure it is at least somewhat reflective of reality.