Only run code style analyzers when nullable warnings are enabled#43972
Merged
sharwell merged 1 commit intodotnet:masterfrom May 6, 2020
Merged
Only run code style analyzers when nullable warnings are enabled#43972sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
Member
|
Is the impact of this change measurable on a clean build? |
jaredpar
approved these changes
May 5, 2020
jaredpar
reviewed
May 5, 2020
| <When Condition="'$(Language)' == 'VB' and '$(RoslynCheckCodeStyle)' == 'true'"> | ||
| <ItemGroup> | ||
| <When Condition="'$(Language)' == 'VB'"> | ||
| <ItemGroup Condition="'$(RoslynCheckCodeStyle)' == 'true'"> |
Member
There was a problem hiding this comment.
The property this is conditioning on is defined in the targets file now, not the props. Think we should move this <Choose> to the targets file as well.
Contributor
Author
There was a problem hiding this comment.
All property groups are evaluated before all item groups. The SDK itself has many examples of cases where default properties are assigned in the targets file (allowing a project file to set values before the defaults are applied as fallback), and items in the props file (allowing a project file to Update one or more items after the item exists).
jaredpar
approved these changes
May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43969