Merged
Conversation
mavasani
reviewed
May 4, 2020
| public async Task InlineVariable1() | ||
| { | ||
| await TestInRegularAndScriptAsync( | ||
| await TestInRegularAndScript1Async( |
Contributor
There was a problem hiding this comment.
Is it possible to rename TestInRegularAndScript1Async to TestInRegularAndScriptAsync, so it is just an overload? I always wonder why we have TestInRegularAndScript1Async method...
Contributor
Author
There was a problem hiding this comment.
not currently because it will be ambiguous. once TestInRegularAndScriptAsync is entirely gone, we can rename TestInRegularAndScript1Async to TestInRegularAndScriptAsync
mavasani
approved these changes
May 4, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent here is to be much more consistent in ttests so that i can then write tools to bulk convert some of our tests over to the new code-style testing library.