Skip to content

Fix MEF usage in several tests#43938

Merged
sharwell merged 4 commits intodotnet:masterfrom
sharwell:use-mef
May 4, 2020
Merged

Fix MEF usage in several tests#43938
sharwell merged 4 commits intodotnet:masterfrom
sharwell:use-mef

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented May 4, 2020

See #42814

@sharwell sharwell requested a review from a team as a code owner May 4, 2020 02:21
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only question is whether any of the [Fact]s need to change to [WPFFact] since they are now relying on MEF.

@sharwell
Copy link
Contributor Author

sharwell commented May 4, 2020

WPFFact is related to threading scenarios. MEF tests only required UseExportProvider on the containing class.

@sharwell sharwell merged commit 47cdfe3 into dotnet:master May 4, 2020
@ghost ghost added this to the Next milestone May 4, 2020
@sharwell sharwell deleted the use-mef branch May 4, 2020 19:19
@JoeRobich JoeRobich modified the milestones: Next, 16.7.P2 May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants