Add more information in our NFW description to help the backend bucket it better#43897
Conversation
| continue; | ||
|
|
||
| return declaringTypeName + "." + methodName; | ||
| } |
There was a problem hiding this comment.
i've manually stepped through to make sure this works.
There was a problem hiding this comment.
Wouldn't walking the exception stack trace (new StackTrace(exception).GetFrames()) be better, finding a namespace that is a strict subnamespace of Microsoft.CodeAnalysis?
Do we want specific method name, or rather group all issues in the same namespace/type together?
There was a problem hiding this comment.
will do that.
There was a problem hiding this comment.
Do we want specific method name, or rather group all issues in the same namespace/type together?
I'd be interested to see how this breaks things down. I think this approach should give us nice unique issues, without over or underbucketing. We can always tweak later :)
src/EditorFeatures/Core/FindReferences/FindReferencesCommandHandler.cs
Outdated
Show resolved
Hide resolved
|
@tmat ? |
| session.PostEvent(faultEvent); | ||
| } | ||
|
|
||
| private static string GetDescription(Exception exception) |
There was a problem hiding this comment.
suggestion: rather than use the Description bucket for this, you could add the frame name to the end of the event, like "vs.ide.vbcs.nonfatalwatson" it could be "vs.ide.vbcs.nonfatalwatson."
That has the additional advantages of easier Kusto querying and freeing up a param for other distinguishing info.
S
There was a problem hiding this comment.
whoops: typo: instead of "vs.ide.vbcs.nonfatalwatson" it could be "vs.ide.vbcs.FrameName"
No description provided.