Skip to content

Fix command name#43882

Merged
CyrusNajmabadi merged 2 commits intodotnet:masterfrom
CyrusNajmabadi:commandName
May 2, 2020
Merged

Fix command name#43882
CyrusNajmabadi merged 2 commits intodotnet:masterfrom
CyrusNajmabadi:commandName

Conversation

@CyrusNajmabadi
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi commented May 1, 2020

Fixes #11300. Have validated fix works:

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 1, 2020 20:50
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@jasonmalinowski
Copy link
Member

@CyrusNajmabadi Ah, I think to ensure this doesn't hit any caching issues, you have to bump this:

"{6cf2e545-6109-4730-8883-cf43d7aec3e1}"=", Menus.ctmenu, 17"

The "17" there is a version number, just bump it to 18.

@sharwell
Copy link
Contributor

sharwell commented May 1, 2020

@jasonmalinowski I never knew that was a thing...

@CyrusNajmabadi CyrusNajmabadi merged commit d9037aa into dotnet:master May 2, 2020
@ghost ghost added this to the Next milestone May 2, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the commandName branch May 2, 2020 17:02
@jasonmalinowski
Copy link
Member

@sharwell I'm not sure how much it's actually used to be honest, but I recall being bit years ago many times where the VSCT cache wasn't rebuilt unless this was bumped. But it's pretty easy for the cache to get rebuilt for other reasons which often masks it.

@JoeRobich JoeRobich modified the milestones: Next, 16.7.P2 May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Go to Implementation" doesn't have a display name in Tools -> Customize

4 participants