Merged
Conversation
CyrusNajmabadi
approved these changes
Apr 30, 2020
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
I love the simplifications!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation attempted to reconnect if ServiceHub disconnected. However, such scenario isn't well supported in the rest of the system.
If the connection can drop anytime then it can drop just before we call Invoke on it, which we wouldn't handle well.
I believe attempting to reconnect or handle re-connection transparently should be handled by the lower layer (JSON RPC), not by Roslyn.