Move MS.CA.VisualBasic to be multi-targeted#43805
Merged
RikkiGibson merged 1 commit intodotnet:masterfrom Apr 30, 2020
Merged
Conversation
Now that we have a work around for the VB runtime reference issue when using the embedded option we can move MS.CA.VisualBasic to be multi-targeted to `netcoreapp3.1` and `netstandard2.0` just as we do for MS.CA.CSharp Related: dotnet/sdk#10591
Member
Author
|
@RikkiGibson @dotnet/roslyn-compiler PTAL |
RikkiGibson
reviewed
Apr 29, 2020
| symbolList = symbolList.Replace("\""", """") | ||
|
|
||
| Dim trimmedSymbolList As String = symbolList.TrimEnd(Nothing) | ||
| Dim trimmedSymbolList As String = symbolList.TrimEnd() |
Member
There was a problem hiding this comment.
Why did these calls have to change?
Member
Author
There was a problem hiding this comment.
There are overloads of this method in netcoreapp3.1 and Nothing is ambiguous for those overloads.
RikkiGibson
approved these changes
Apr 29, 2020
333fred
approved these changes
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a work around for the VB runtime reference issue when
using the embedded option we can move MS.CA.VisualBasic to be
multi-targeted to
netcoreapp3.1andnetstandard2.0just as we dofor MS.CA.CSharp
Related: dotnet/sdk#10591