Skip to content

Do not install Roslyn.VisualStudio.InteractiveComponents.vsix for integration tests#43727

Merged
jasonmalinowski merged 1 commit intorelease/dev16.6from
dev/tmat/icvsix
Apr 27, 2020
Merged

Do not install Roslyn.VisualStudio.InteractiveComponents.vsix for integration tests#43727
jasonmalinowski merged 1 commit intorelease/dev16.6from
dev/tmat/icvsix

Conversation

@tmat
Copy link
Member

@tmat tmat commented Apr 27, 2020

No description provided.

@tmat tmat requested a review from a team as a code owner April 27, 2020 20:26
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a internal conversation, sounds like this is necessary in this branch since in master we had already deleted this VSIX. The theory is this VSIX isn't installable on our current integration test images since it disappeared from the base image.

@jasonmalinowski
Copy link
Member

Going to merge this bypassing CI requirements. We believe the next step is to backport #43628 to this branch and I'll make a PR doing that momentarily, but this at least has improved the situation in that our tests are actually running now, unlike before where we failed to even deploy them. Since we have few other PRs going into this branch right now this at least lets those other PRs see which additional tests they might be breaking.

@jasonmalinowski jasonmalinowski merged commit 8c3cb3f into release/dev16.6 Apr 27, 2020
@jasonmalinowski jasonmalinowski deleted the dev/tmat/icvsix branch April 27, 2020 22:49
@jasonmalinowski
Copy link
Member

Thanks @tmat for the quick diagnosis and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants