🐇 Avoid using an ArrayBuilder for IntervalTree<T>.Any#43715
Merged
sharwell merged 1 commit intodotnet:masterfrom Apr 28, 2020
Merged
🐇 Avoid using an ArrayBuilder for IntervalTree<T>.Any#43715sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
jasonmalinowski
approved these changes
Apr 27, 2020
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Collections/IntervalTree`1.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 27, 2020
ce8b920 to
81dbb93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reduces the cost of parallel calls to
IntervalTree<T>.Anyon highly-parallel machines.On a 2990WX, the measured improvement for parallel formatting of Roslyn.sln was more than 15 seconds of CPU time.