Skip to content

Don't remove casts in conditional expressions if it would change the meaning.#43703

Merged
4 commits merged intodotnet:masterfrom
CyrusNajmabadi:removeCastConditional
Apr 27, 2020
Merged

Don't remove casts in conditional expressions if it would change the meaning.#43703
4 commits merged intodotnet:masterfrom
CyrusNajmabadi:removeCastConditional

Conversation

@CyrusNajmabadi
Copy link
Contributor

Fixes #21613

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 27, 2020 03:35
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 452a00f into dotnet:master Apr 27, 2020
@CyrusNajmabadi CyrusNajmabadi deleted the removeCastConditional branch April 27, 2020 20:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cast refactoring should not remove cast if it changes the type of the value.

2 participants