Fix a bunch of bugs around dynamic files being added and removed#43620
Merged
jasonmalinowski merged 5 commits intodotnet:release/dev16.6from Apr 30, 2020
Merged
Conversation
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs
Outdated
Show resolved
Hide resolved
260d9ab to
12672dd
Compare
Member
Author
|
@CyrusNajmabadi thanks for the feedback, ready for review again. |
12672dd to
c381302
Compare
Contributor
|
@jasonmalinowski can you please avoid force pushing. it breaks CR entirely and i have to start over agian. |
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs
Outdated
Show resolved
Hide resolved
This now correctly handles a file being removed and added a second time, and also a file being removed if there was no dynamic file provided originally. This also adds locks around the operations to ensure there aren't trivial races. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1107122
c381302 to
90bdcfa
Compare
Member
Author
|
@CyrusNajmabadi Ready for review again, https://github.com/dotnet/roslyn/compare/c38130218e542a8aa687170164cb7192568f694d..90bdcfa9891189cfdbc7447b2d992e89a151a0d8 is the diff against what you previously reviewed. |
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 28, 2020
src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioProject.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This now correctly handles a file being removed and added a second time, and also a file being removed if there was no dynamic file provided originally.
File at a time may make this easier to review.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1107122