Remove unused options in EditorCompletionOptions#43614
Merged
sharwell merged 1 commit intodotnet:masterfrom May 4, 2020
Merged
Remove unused options in EditorCompletionOptions#43614sharwell merged 1 commit intodotnet:masterfrom
sharwell merged 1 commit intodotnet:masterfrom
Conversation
CyrusNajmabadi
approved these changes
Apr 23, 2020
Contributor
|
Did you verify these are not used by internal partners through IVT? |
Contributor
Author
|
@mavasani Not verified, but even if they are used through IVTs they do not have any impact. The values are not persisted and are not hooked up to any features. |
Contributor
Author
|
@mavasani The only references I see are in RoslynTaoActions and RoslynETAHost. I believe neither of these are in use anymore. |
mavasani
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.