Mark APIs as shipped.#43613
Merged
333fred merged 2 commits intodotnet:release/dev16.6from Apr 29, 2020
Merged
Conversation
jasonmalinowski
approved these changes
Apr 23, 2020
sharwell
previously requested changes
Apr 23, 2020
sharwell
reviewed
Apr 23, 2020
| static Microsoft.CodeAnalysis.CSharp.SyntaxFactory.XmlTextNewLine(string text, bool continueXmlDocumentationComment) -> Microsoft.CodeAnalysis.SyntaxToken | ||
| static Microsoft.CodeAnalysis.CSharp.SyntaxFactory.XmlTextNewLine(string text) -> Microsoft.CodeAnalysis.SyntaxToken |
Contributor
There was a problem hiding this comment.
📝 These moves are going to make it difficult to compare the changes between releases. Is there a way to avoid them?
Member
Author
There was a problem hiding this comment.
We should take these now, and then we won't have to deal with them the next time we ship. This is because we're running a sort, and for some reason the current file is not sorted. If we don't do this, it's going to be much more of a pain.
Member
Author
|
@dotnet/roslyn-compiler for review. I included the source-generator changes in this because it will give us a good way of rounding up exactly the breaking changes we make to the API as we evolve it for publishing. |
chsienki
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran scripts/PublicAPI/mark-shipped.cmd. No code change.