Skip to content

Add unit-tests.#43604

Merged
AlekseyTs merged 1 commit intodotnet:masterfrom
AlekseyTs:Issue24517
Apr 24, 2020
Merged

Add unit-tests.#43604
AlekseyTs merged 1 commit intodotnet:masterfrom
AlekseyTs:Issue24517

Conversation

@AlekseyTs
Copy link
Contributor

@AlekseyTs AlekseyTs commented Apr 23, 2020

Closes #24517

@AlekseyTs AlekseyTs added Area-Compilers Test Test failures in roslyn-CI Feature - Tuples Tuples labels Apr 23, 2020
@AlekseyTs AlekseyTs requested a review from a team as a code owner April 23, 2020 16:24
jcouv
jcouv approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@jcouv jcouv self-assigned this Apr 23, 2020
@AlekseyTs
Copy link
Contributor Author

AlekseyTs commented Apr 23, 2020

@dotnet/roslyn-infrastructure
It looks like CI got stuck. Here it shows the jobs as failed https://dev.azure.com/dnceng/public/_build/results?buildId=613788&view=results . And here https://github.com/dotnet/roslyn/pull/43604/checks?check_run_id=612877314 they are shown as still running. I assume because of that the "Re-run' button is not shown. What is the way out of this?

@AlekseyTs AlekseyTs merged commit 50fc72f into dotnet:master Apr 24, 2020
@ghost ghost added this to the Next milestone Apr 24, 2020
@sharwell sharwell modified the milestones: Next, temp, 16.7.P1 Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers Feature - Tuples Tuples Test Test failures in roslyn-CI

Projects

None yet

Milestone

16.7.P1

Development

Successfully merging this pull request may close these issues.

Invalid expression tree code emitted when using ValueTuple constructors

4 participants

@AlekseyTs @RikkiGibson @jcouv @sharwell