Move the 'finding' portoin of rename out of process.#43554
Merged
16 commits merged intodotnet:masterfrom Apr 22, 2020
Merged
Conversation
CyrusNajmabadi
commented
Apr 22, 2020
| throw new ArgumentException(WorkspacesResources.Symbols_project_could_not_be_found_in_the_provided_solution, nameof(symbol)); | ||
|
|
||
| if (string.IsNullOrEmpty(newName)) | ||
| throw new ArgumentException(nameof(newName)); |
Contributor
Author
There was a problem hiding this comment.
public methods get real argument checks. internal methods get contract checks.
ryzngard
reviewed
Apr 22, 2020
src/Features/Core/Portable/UseAutoProperty/AbstractUseAutoPropertyCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
ryzngard
reviewed
Apr 22, 2020
ryzngard
reviewed
Apr 22, 2020
ryzngard
reviewed
Apr 22, 2020
ryzngard
reviewed
Apr 22, 2020
ryzngard
reviewed
Apr 22, 2020
ryzngard
reviewed
Apr 22, 2020
ryzngard
reviewed
Apr 22, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed commit by commit.
Rename is composed of two parts. The first finds the all the places to rename (and only needs to run once). The second checks for conflicts at all those locations whenever the user updates the name (so it may run many times). This PR moves the first part of this out of process.