Fixed MakeFieldReadonlyCodeFixProvider for volatile fields.#43542
Merged
CyrusNajmabadi merged 3 commits intodotnet:masterfrom Apr 22, 2020
Merged
Fixed MakeFieldReadonlyCodeFixProvider for volatile fields.#43542CyrusNajmabadi merged 3 commits intodotnet:masterfrom
CyrusNajmabadi merged 3 commits intodotnet:masterfrom
Conversation
| if (declarationDeclarators.Count == fieldDeclarators.Count()) | ||
| { | ||
| editor.SetModifiers(fieldDeclarators.Key, editor.Generator.GetModifiers(fieldDeclarators.Key) | DeclarationModifiers.ReadOnly); | ||
| var modifiers = editor.Generator.GetModifiers(fieldDeclarators.Key) - DeclarationModifiers.Volatile | DeclarationModifiers.ReadOnly; |
Contributor
There was a problem hiding this comment.
- using
-here is very uncommon. Generally to wipe the bits here it's preferred to dox & ~y. - this pattern is repeated twice. can you extract a helper for this?
Contributor
Author
There was a problem hiding this comment.
This isn't an Enum. DeclarationModifiers doesn't have override for ~ operator.
src/Analyzers/Core/CodeFixes/MakeFieldReadonly/AbstractMakeFieldReadonlyCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
…ldReadonlyCodeFixProvider.cs Co-Authored-By: CyrusNajmabadi <cyrus.najmabadi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42759