Skip to content

Implement SegmentedArray<T>#43502

Merged
sharwell merged 7 commits intodotnet:masterfrom
sharwell:segmented-array
Jun 11, 2020
Merged

Implement SegmentedArray<T>#43502
sharwell merged 7 commits intodotnet:masterfrom
sharwell:segmented-array

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Apr 20, 2020 •
edited
Loading

Implements SegmentedArray<T>, which is intended to serve as a replacement for T[] that does not place objects in the Large Object Heap. More complex data types (e.g. a replacement for List<T> or Dictionary<TKey, TValue>) could be implemented on top of this type.

@sharwell sharwell marked this pull request as ready for review April 22, 2020 16:32
@sharwell sharwell requested a review from a team as a code owner April 22, 2020 16:32
@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented Apr 22, 2020

Done with pass.

@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented Apr 22, 2020

i see. you're thinking about this as a bulding block piece. In htat case i like it a lot more. But it would be nice to see how htat would work. i.e. how a SegmentedList would use SegmentedArray to make a variable length construct.

@sharwell
Copy link
Contributor Author

sharwell commented Apr 23, 2020

... how a SegmentedList would use SegmentedArray to make a variable length construct.

It's exactly the same as how List<T> is implemented against T[]. Either way it'll be coming shortly.

CyrusNajmabadi
CyrusNajmabadi approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note: i didn't check any of hte math/shifting/bit-operations. I presume the tests are sufficient to validate here :)

@sharwell sharwell mentioned this pull request May 15, 2020
Closed
@sharwell
Copy link
Contributor Author

sharwell commented Jun 10, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 10, 2020

Azure Pipelines successfully started running 2 pipeline(s).

@sharwell sharwell merged commit d3298d8 into dotnet:master Jun 11, 2020
@ghost ghost added this to the Next milestone Jun 11, 2020
@sharwell sharwell deleted the segmented-array branch June 11, 2020 16:40
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genlu genlu genlu left review comments

+2 more reviewers

@jkotas jkotas jkotas left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE

Projects

None yet

Milestone

16.7.P4

Development

Successfully merging this pull request may close these issues.

6 participants

@sharwell @CyrusNajmabadi @genlu @jkotas @dibarbet @jinujoseph