Use captured foreach variable#43357
Merged
sharwell merged 2 commits intodotnet:masterfrom Apr 15, 2020
Merged
Conversation
mavasani
approved these changes
Apr 14, 2020
Contributor
|
In this case I don't think it makes a difference. The |
Contributor
Author
Yup, you are right! I was mistaking it with the scenario where the variable is declared outside the loop - i.e. for loop index variable. Removed the redundant local. |
Contributor
Author
|
Heh, it seems like the foreach scenario existed, but it was changed in C# 5.0. |
CyrusNajmabadi
approved these changes
Apr 14, 2020
Contributor
|
Agreed with @sharwell's assessment. And, even if this was captured, this is safe to do :) |
sharwell
approved these changes
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the behaviour of lambda captures with foreach variables, the code might be hiding a bug.
cc @mavasani @CyrusNajmabadi