Merged
Conversation
2332d78 to
68d4b98
Compare
68d4b98 to
f89d54e
Compare
CyrusNajmabadi
commented
Apr 13, 2020
| // one of these has never been invoked. It's always after an item that has been | ||
| // invoked. | ||
| // we've invoked both of these before. Order by how recently it was invoked. | ||
| (ca, tuple) => tuple.Item1.IndexOf(GetSortTitle(ca)), |
Contributor
Author
There was a problem hiding this comment.
this approach just basically does not work. a non-invoked item will have a negative index, an invoked item will have a positive index.
caf8964 to
c9d80b4
Compare
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regressed with #37894
The problem there is that you could have a wrapping item that was never invoke compared against one that was invoked. The non-invoked wrapping item would then show up with a negative index (because it wasn't in hte MRU list), but the invoked one would have a positive index. Negatie is less than positive. So the non-inokved one would now have priority!
We odn't have tests here. And that's on me. Will def add a test here to validate that this approach works.