Adjust nullability of a target type for an argument of a lifted binary operator.#43165
Merged
AlekseyTs merged 2 commits intodotnet:release/dev16.6from Apr 9, 2020
Merged
Adjust nullability of a target type for an argument of a lifted binary operator.#43165AlekseyTs merged 2 commits intodotnet:release/dev16.6from
AlekseyTs merged 2 commits intodotnet:release/dev16.6from
Conversation
…y operator. Fixes dotnet#3936.
Contributor
Author
1 similar comment
Contributor
Author
333fred
reviewed
Apr 8, 2020
| ParameterSymbol parameter, | ||
| TypeWithState operandType) | ||
| { | ||
| TypeWithAnnotations targetTypeWithNullability = parameter.TypeWithAnnotations; |
Member
There was a problem hiding this comment.
targetTypeWithNullability [](start = 40, length = 25)
Nit: Not a fan of the naming. Nullability in this file generally means either annotation state or flow state. This is really possiblyLiftedTargetType. #ByDesign
Contributor
Author
There was a problem hiding this comment.
The name matches parameter name of the VisitConversion method that is called below.
In reply to: 405826407 [](ancestors = 405826407)
333fred
reviewed
Apr 8, 2020
| return x6 == y6; | ||
| } | ||
|
|
||
| bool M7(DateTime? x7, S? y7) |
Member
There was a problem hiding this comment.
Consider adding a case for DateTime x8, S y8 #Resolved
333fred
approved these changes
Apr 8, 2020
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 1). Just a couple of minor nits.
cston
approved these changes
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39361.