Port MakeLocalFunctionStatic analyzer and tests to shared layer#43061
Merged
3 commits merged intodotnet:masterfrom Apr 3, 2020
Merged
Port MakeLocalFunctionStatic analyzer and tests to shared layer#430613 commits merged intodotnet:masterfrom
3 commits merged intodotnet:masterfrom
Conversation
CodeFix has not yet been ported because it depends on internal CodeGenerationSymbolFactory APIs. dotnet#43056 tracks making these APIs public and subsequently porting the fixer. To enable porting the tests, I have added a workaround in CodeStyle layer test framework to use the IDE code fixer with the CodeStyle layer analyzer for tests.
mavasani
commented
Apr 3, 2020
|
|
||
| namespace Microsoft.CodeAnalysis.CSharp.MakeLocalFunctionStatic | ||
| { | ||
| internal static class MakeLocalFunctionStaticHelper |
Contributor
Author
There was a problem hiding this comment.
Existing code just split into separate helper types for analyzer and fixer.
mavasani
commented
Apr 3, 2020
| { | ||
| syntaxEditor.ReplaceNode( | ||
| identifierNode, | ||
| (node, generator) => generator.IdentifierName(parameter.Name.ToIdentifierToken()).WithTriviaFrom(node)); |
Contributor
Author
There was a problem hiding this comment.
Reverted this change in last commit.
Contributor
There was a problem hiding this comment.
unfortunate if they have different behavior. i want your change here to be good :)
Contributor
Author
There was a problem hiding this comment.
Tests passed either way, just reverted as wasn't necessary.
mavasani
commented
Apr 3, 2020
| } | ||
|
|
||
| return AddStaticModifier(localFunctionWithNewParameters, CSharpSyntaxGenerator.Instance); | ||
| return AddStaticModifier(localFunctionWithNewParameters, SyntaxGenerator.GetGenerator(document)); |
Contributor
Author
There was a problem hiding this comment.
Reverted this change in last commit.
CyrusNajmabadi
approved these changes
Apr 3, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit: File moves
Second commit: xlf and resx changes
Third commit: Revert some unintentional changes to fixer