Dismiss Completion when Signature Help is explicitly invoked#42511
Merged
dpoeschl merged 4 commits intodotnet:release/dev16.6-preview2from Mar 19, 2020
Merged
Conversation
Contributor
Author
|
@CyrusNajmabadi Implemented this on our side as discussed. Let me know if you have concerns with this approach. |
Contributor
Author
|
@CyrusNajmabadi Thanks for taking a look. I've taken this out of Draft state and added an integration test. Can you take another look and sign off if appropriate? Thanks! |
dpoeschl
commented
Mar 19, 2020
Contributor
Author
There was a problem hiding this comment.
FYI @AmadeusW that we're using the editor's completion broker for this.
CyrusNajmabadi
approved these changes
Mar 19, 2020
Contributor
Author
|
@jinujoseph |
4f4033e to
faebe68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42484
Customer and scenario info
Who is impacted by this bug?
C# users who have IntelliCode argument completions enabled, as well as argument list completion enabled (we plan to make these defaults by GA).
Bugs Fixed
Fixes #42484
What is the customer scenario and impact of the bug?
When a user types an argument list, say
Foo(, Completion and Signature Help now show at the same time. If the user wants to interact with Signature Help via the keyboard, they need to either hit Esc to dismiss Completion (pre-existing behavior), or explicitly invoke Signature Help again (the change in this PR).What is the workaround?
The user can hit Esc instead of explicitly invoking Signature Help, or they can use the mouse to interact with Signature Help.
How was the bug found?
Unit tests & dogfooding.
If this fix is for a regression - what had regressed, when was the regression introduced, and why was the regression originally missed?
It's not a "regression", but rather an intentional behavioral change for which we are trying to minimize the impact.
Testing
An integration test was added, and I did manual testing.