Tweak how we generate the IDisposable.Dispose pattern.#42426
Merged
CyrusNajmabadi merged 23 commits intodotnet:masterfrom Mar 17, 2020
Merged
Tweak how we generate the IDisposable.Dispose pattern.#42426CyrusNajmabadi merged 23 commits intodotnet:masterfrom
CyrusNajmabadi merged 23 commits intodotnet:masterfrom
Conversation
mavasani
reviewed
Mar 15, 2020
sharwell
reviewed
Mar 15, 2020
sharwell
reviewed
Mar 15, 2020
sharwell
reviewed
Mar 15, 2020
sharwell
suggested changes
Mar 16, 2020
CyrusNajmabadi
commented
Mar 16, 2020
…tInterfaceService.CodeAction.cs
Contributor
Author
|
Ok. Have moved to a model where this is almost all done with standard code gen. |
CyrusNajmabadi
commented
Mar 16, 2020
| Module Program | ||
| Sub Main() | ||
| If True Then | ||
|
|
Contributor
Author
There was a problem hiding this comment.
changed because i tweaked the formatter to not introduce a blank line with nested if-statements + elastic trivia.
CyrusNajmabadi
commented
Mar 16, 2020
| </data> | ||
| <data name="TODO_colon_uncomment_the_following_line_if_the_finalizer_is_overridden_above" xml:space="preserve"> | ||
| <value>TODO: uncomment the following line if the finalizer is overridden above.</value> | ||
| </data> |
Contributor
Author
There was a problem hiding this comment.
all resources moved to features layer.
CyrusNajmabadi
commented
Mar 16, 2020
| return ifStatement.ReplaceToken( | ||
| ifStatement.GetLastToken(), | ||
| ifStatement.GetLastToken().WithPrependedLeadingTrivia(trivia)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
i couldn't find a language agnostic way to do this. So VB and C# both have way to add a comment inside their if-block.
CyrusNajmabadi
commented
Mar 16, 2020
| return options.AutoInsertionLocation | ||
| ? AddMembersToAppropiateLocationInDestination(destination, filteredMembers, availableIndices, options, cancellationToken) | ||
| : AddMembersToEndOfDestination(destination, filteredMembers, availableIndices, options, cancellationToken); | ||
| : AddMembersToEndOfDestination(destination, filteredMembers, options, cancellationToken); |
Contributor
Author
There was a problem hiding this comment.
unused param.
CyrusNajmabadi
commented
Mar 16, 2020
| INamespaceOrTypeSymbol destination, | ||
| Func<SyntaxNode, CodeGenerationOptions, IList<bool>, CancellationToken, SyntaxNode> declarationTransform, | ||
| CodeGenerationOptions options, | ||
| IEnumerable<ISymbol> members, |
Contributor
Author
There was a problem hiding this comment.
unused param.
CyrusNajmabadi
commented
Mar 16, 2020
| TypeOf previousStatement Is TypeStatementSyntax Then | ||
| TypeOf previousStatement Is TypeStatementSyntax OrElse | ||
| TypeOf previousStatement Is IfStatementSyntax Then | ||
| Return GetActualLines(previousToken, currentToken, 1) |
Contributor
Author
There was a problem hiding this comment.
tweaked elastic formatting of nested ifs to not put in a blank line.
sharwell
approved these changes
Mar 16, 2020
| }} | ||
| #endregion"; | ||
| // {string.Format(FeaturesResources.Do_not_change_this_code_Put_cleanup_code_in_0_method, "Dispose(bool disposing)")} | ||
| Dispose(disposing: true); |
Contributor
There was a problem hiding this comment.
💭 I'm not a huge fan of making this a named argument, but I'm ignoring it for now since the long-term goal is to remove the Dispose(bool) method altogether.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9760
A few improvements:
#regions. We stopped generating regions for interfaces years ago. This brings IDisposable in line with that.