Enable file header analyzer (IDE0073) in build#42349
Merged
4 commits merged intodotnet:masterfrom Mar 16, 2020
Merged
Conversation
CyrusNajmabadi
approved these changes
Mar 12, 2020
Contributor
|
@mavasani I'd like to fix a few bugs I see from this pull request, and then resubmit it so we can see they are fixed before merging |
JoeRobich
approved these changes
Mar 12, 2020
Contributor
Author
|
@sharwell Sounds good. I will wait for your signoff on this PR before merge. |
jasonmalinowski
approved these changes
Mar 12, 2020
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
I'm impressed we only had this many files missing the header!
sharwell
approved these changes
Mar 16, 2020
sharwell
approved these changes
Mar 16, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit moves us to a newer CodeStyle NuGet package and enables IDE0073 as a warning.
Second commit was result of a Fix all in solution operation for its code fix. No manual code changes were done. I skimmed through each changed file to validate the fix did the appropriate change.
Thanks to @sharwell for quick turnaround in implementing this analyzer and moving it to CodeStyle NuGet package for CI support.
Closes #20785