Move designer attribute scanning out-of-process#42346
Merged
CyrusNajmabadi merged 63 commits intodotnet:masterfrom Mar 15, 2020
Merged
Move designer attribute scanning out-of-process#42346CyrusNajmabadi merged 63 commits intodotnet:masterfrom
CyrusNajmabadi merged 63 commits intodotnet:masterfrom
Conversation
CyrusNajmabadi
commented
Mar 11, 2020
src/VisualStudio/CSharp/Test/DesignerAttribute/DesignerAttributeServiceTests.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Mar 11, 2020
| // cache the update service for cps projects. Computed on demand (slow), but then cached for | ||
| // quick responses after that. | ||
| private readonly ConcurrentDictionary<ProjectId, IProjectItemDesignerTypeUpdateService> _cpsProjects | ||
| = new ConcurrentDictionary<ProjectId, IProjectItemDesignerTypeUpdateService>(); |
Contributor
Author
There was a problem hiding this comment.
Copied the code for this (including how it is initialized) from the previous impl.
CyrusNajmabadi
commented
Mar 11, 2020
...sualStudio/Core/Def/Implementation/DesignerAttribute/VisualStudioDesignerAttributeService.cs
Outdated
Show resolved
Hide resolved
…ualStudioDesignerAttributeService.cs
CyrusNajmabadi
commented
Mar 11, 2020
| // Make sure this is a document we still know about when OOP notifies us. | ||
| var document = project.GetDocument(info.DocumentId); | ||
| if (document == null) | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
the rest of the code in this method matches what we previously did in the last incremental analyzer. the code is copied almost unchanged.
Member
Seems unnecessary. I don't see any RPCs here (which is a good thing, let's just unit test the DesignAttributeHelpers here). DesignerAttributeHelpers just works with local document/project. Refers to: src/VisualStudio/CSharp/Test/DesignerAttribute/DesignerAttributeServiceTests.cs:92 in 7254c99. [](commit_id = 7254c99, deletion_comment = False) |
Contributor
Author
|
Updated tests. |
tmat
reviewed
Mar 13, 2020
src/Workspaces/Remote/ServiceHub/Services/DesignerAttribute/RemoteDesignerAttributeService.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Mar 13, 2020
...sualStudio/Core/Def/Implementation/DesignerAttribute/VisualStudioDesignerAttributeService.cs
Outdated
Show resolved
Hide resolved
tmat
approved these changes
Mar 13, 2020
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42186