Improve error recovery when parsing incomplete base lists. #42258
Merged
jcouv merged 5 commits intodotnet:masterfrom Mar 17, 2020
Merged
Improve error recovery when parsing incomplete base lists. #42258jcouv merged 5 commits intodotnet:masterfrom
jcouv merged 5 commits intodotnet:masterfrom
Conversation
Contributor
Author
CyrusNajmabadi
commented
Mar 8, 2020
|
|
||
| _termState = saveTerm; | ||
| var baseList = this.ParseBaseList(); | ||
| _termState = saveTerm; |
Contributor
Author
There was a problem hiding this comment.
this is the actual change. as long we we're in the base list, we stay in the PossibleAggregateClauseStartOrStop state so that we consider tokens like { something that should stop us from parsing the base-list.
jasonmalinowski
approved these changes
Mar 9, 2020
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
IDE test looks good, but I'm not looking at the compiler portion.
Contributor
Author
333fred
approved these changes
Mar 10, 2020
Member
333fred
left a comment
There was a problem hiding this comment.
Can you please add another parsing test for a base list followed by a :? Otherwise, LGTM.
Contributor
Author
|
@dotnet/roslyn-compiler Could i get another set of eyes please? |
jcouv
approved these changes
Mar 17, 2020
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (iteration 5). Will go ahead with merge/squash.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30102