Track changed option keys in global option service so the serializabl…#42257
Merged
3 commits merged intodotnet:masterfrom Mar 12, 2020
Merged
Track changed option keys in global option service so the serializabl…#422573 commits merged intodotnet:masterfrom
3 commits merged intodotnet:masterfrom
Conversation
…e option set in the solution snapshot always has up-to-date changed option keys. This ensures that subsequent attempts to apply this option set to a different workspace, say RemoteWorkspace, correctly apply the changed options.
CyrusNajmabadi
approved these changes
Mar 8, 2020
… in the changed options keys for the solution snapshot. Also updated the newly added unit test to explicitly test this scenario that was caught by integration tests.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e option set in the solution snapshot always has up-to-date changed option keys. This ensures that subsequent attempts to apply this option set to a different workspace, say RemoteWorkspace, correctly apply the changed options.
Thanks @CyrusNajmabadi for finding this bug!