Record usage of TupleElementNamesAttribute in VB#42048
Record usage of TupleElementNamesAttribute in VB#42048AlekseyTs merged 2 commits intodotnet:features/UsedAssemblyReferencesfrom
Conversation
|
dotnet/roslyn-compiler |
| Dim constructorSymbol = TryCast(GetWellKnownTypeMember(WellKnownMember.System_Runtime_CompilerServices_TupleElementNamesAttribute__ctorTransformNames), MethodSymbol) | ||
| Return constructorSymbol IsNot Nothing AndAlso | ||
| Binder.GetUseSiteInfoForWellKnownTypeMember(constructorSymbol, WellKnownMember.System_Runtime_CompilerServices_TupleElementNamesAttribute__ctorTransformNames, | ||
| embedVBRuntimeUsed:=False).DiagnosticInfo Is Nothing |
There was a problem hiding this comment.
DiagnosticInfo [](start = 94, length = 14)
So, if the attribute ctor is obsolete with a warning this returns false? If that is the intended behavior, why? #Resolved
There was a problem hiding this comment.
So, if the attribute ctor is obsolete with a warning this returns false? If that is the intended behavior, why?
There is no change around this scenario. Obsolete checks are performed separately and presence of an Obsolete attributes on a symbol does not have any effect on DiagnosticInfo. Also, in VB the DiagnosticInfo property never returns warnings (unlike in C#).
In reply to: 386555701 [](ancestors = 386555701)
|
@dotnet/roslyn-compiler Please review, need a second sign-off for a small change. |
1 similar comment
|
@dotnet/roslyn-compiler Please review, need a second sign-off for a small change. |
No description provided.