Move bunch of analyzer base types and test utility types into shared …#41992
Move bunch of analyzer base types and test utility types into shared …#419922 commits merged intodotnet:masterfrom
Conversation
| EndProject | ||
| Project("{778DAE3C-4631-46EA-AA77-85C1314464D9}") = "vbi", "src\Interactive\vbi\vbi.vbproj", "{706CFC25-B6E0-4DAA-BCC4-F6FAAFEEDF87}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.CodeStyle.UnitTestUtilities", "src\CodeStyle\Core\Tests\Microsoft.CodeAnalysis.CodeStyle.UnitTestUtilities.csproj", "{21A59DB8-E9E0-42EB-A599-457C5BC87FC3}" |
There was a problem hiding this comment.
Renaming Microsoft.CodeAnalysis.CodeStyle.UnitTests to Microsoft.CodeAnalysis.CodeStyle.UnitTestUtilities is the core change to the sln file and the only compiler layer change. Other changes got pulled in by VS automatically.
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using Microsoft.CodeAnalysis.Options; | ||
|
|
||
| #if CODE_STYLE |
There was a problem hiding this comment.
All the #if CODE_STYLE added in this PR are temporary until Sam's changes unifies options infrastructure in shared layer.
| /// <param name="tagIndices"> | ||
| /// a map of location tag to index in additional locations. | ||
| /// <see cref="AbstractRemoveUnnecessaryParenthesesDiagnosticAnalyzer{TLanguageKindEnum, TParenthesizedExpressionSyntax}"/> for an example of usage. | ||
| /// "AbstractRemoveUnnecessaryParenthesesDiagnosticAnalyzer" for an example of usage. |
There was a problem hiding this comment.
We can revert this change once this analyzer is moved to the shared analyzers layer.
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.CodeFix.Testing.XUnit" Version="$(MicrosoftCodeAnalysisCSharpCodeFixTestingXUnitVersion)" /> | ||
| </ItemGroup> | ||
| <ItemGroup Label="Project References"> | ||
| <!-- Directly reference the Workspaces project so we always test against the latest Roslyn bits --> |
There was a problem hiding this comment.
This change is needed to ensure that we always run Code style tests against the latest Roslyn Compiler and Workspaces bits.
|
@CyrusNajmabadi Seems like your last PR merge causes a build break (#41416). All the subsequent PRs are failing with the following nullability error in |
I don't understand how that's possible. The PR was totally passing green. Does our CI system allow merging in without revalidating the PR against master? Seems like a big hole if so. |
|
@CyrusNajmabadi Not sure. However, #42001 should fix the break. |
…layer