Clean up project, document and solution infos#41901
Merged
tmat merged 10 commits intodotnet:masterfrom Feb 27, 2020
Merged
Conversation
Member
Author
|
@jasonmalinowski @dotnet/roslyn-ide PTAL |
a4627aa to
dcae0fb
Compare
Member
Author
|
@CyrusNajmabadi Feedback addressed. |
CyrusNajmabadi
approved these changes
Feb 26, 2020
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
Overall i'm ok with this. There are a couple of points that it would be good to cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing tests and argument validation. Moves argument validation closer to exposed public surface.
Fixes #37880