Skip to content

Test convert nullable to non-nullable using custom awaitable#41726

Merged
RikkiGibson merged 1 commit intodotnet:masterfrom
skarllot-forking:master
Feb 18, 2020
Merged

Test convert nullable to non-nullable using custom awaitable#41726
RikkiGibson merged 1 commit intodotnet:masterfrom
skarllot-forking:master

Conversation

@skarllot
Copy link
Copy Markdown
Contributor

@skarllot skarllot commented Feb 15, 2020

Test reporting on methods that returns ConfiguredTaskAwaitable (closes #39417).

@skarllot skarllot requested a review from a team as a code owner February 15, 2020 21:31
@jcouv jcouv self-assigned this Feb 16, 2020
@jcouv jcouv added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Test Test failures in roslyn-CI labels Feb 16, 2020
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@RikkiGibson RikkiGibson merged commit 0b2e84a into dotnet:master Feb 18, 2020
@RikkiGibson
Copy link
Copy Markdown
Member

Thanks for your contribution @skarllot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Test Test failures in roslyn-CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CS8600: Should report on methods that returns ConfiguredTaskAwaitable

3 participants