Skip to content

Allow structures to implement nested interfaces as we do for classes.#41711

Merged
AlekseyTs merged 1 commit intodotnet:masterfrom
AlekseyTs:Issue41501
Feb 15, 2020
Merged

Allow structures to implement nested interfaces as we do for classes.#41711
AlekseyTs merged 1 commit intodotnet:masterfrom
AlekseyTs:Issue41501

Conversation

@AlekseyTs
Copy link
Copy Markdown
Contributor

Fixes #41501.

@AlekseyTs AlekseyTs requested a review from a team as a code owner February 14, 2020 23:13
@gafter
Copy link
Copy Markdown
Member

gafter commented Feb 15, 2020

If this is not tied to a language version, it would result in a forward breaking change (someone writing a program for C# 8.0 in a later version of the compiler could produce a program that will not compile in an earlier version of the compiler). If that is what we intend, we need to document the break.

@gafter
Copy link
Copy Markdown
Member

gafter commented Feb 15, 2020

My mistake. I see this was an unintentional regression.

Copy link
Copy Markdown
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler Please review a very small bug fix, need a second sign-off.

@AlekseyTs AlekseyTs merged commit bff5164 into dotnet:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C# Struct Inherited Interface Causes Cycle In Interface Hierarchy

3 participants