Merged
Conversation
Contributor
I am not aware of a situation where this is correct. It's fine to check that the token is cancelled, but it is not safe to assume the cancellation token is the same one that will appear in the exception. This would disallow things like linked cancellation tokens. |
sharwell
previously requested changes
Feb 7, 2020
Member
Author
|
@sharwell I have changed the condition for now. We can follow up with a stronger one later. |
Contributor
|
@tmat Thanks! The UI won't let me dismiss the review while it's still in draft. |
JoeRobich
reviewed
Feb 20, 2020
src/VisualStudio/Core/Def/Implementation/Remote/ServiceHubRemoteHostClient.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Feb 26, 2020
ryzngard
reviewed
Feb 26, 2020
ryzngard
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few improvements in unexpected exception reporting.
FatalError.Report*methods for all sites that report fatal or non-fatal Watson.FatalError.Report*ensures that NFW is reported only once for the given exception even if the exception is passed toFatalError.Reportmultiple times (as it may propagate on the stack).FatalError.Report*UnlessCancelled*that take cancellation token and check if it matches the one in theCancellationException. These are intended to replace the ones without the token at all call sites in future.