Skip to content

Print the VS display version in CI logs#41471

Merged
JoeRobich merged 2 commits intomasterfrom
dev/jorobich/log-vs-version
Feb 7, 2020
Merged

Print the VS display version in CI logs#41471
JoeRobich merged 2 commits intomasterfrom
dev/jorobich/log-vs-version

Conversation

@JoeRobich
Copy link
Copy Markdown
Member

@JoeRobich JoeRobich commented Feb 6, 2020 •
edited
Loading

Before:

Time Elapsed 00:12:19.01
Downloading https://raw.githubusercontent.com/dotnet/roslyn/master/eng/config/PublishData.json
Using VS Instance 1dd8ef0c at "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview"
Uninstalling old Roslyn VSIX

After:

Time Elapsed 00:12:19.01
Downloading https://raw.githubusercontent.com/dotnet/roslyn/master/eng/config/PublishData.json
Using VS Instance 1dd8ef0c (16.4.0 Preview 1.0) at "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview"
Uninstalling old Roslyn VSIX

@JoeRobich JoeRobich added Area-Infrastructure PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. labels Feb 6, 2020
@JoeRobich JoeRobich removed the PR For Personal Review Only The PR doesn’t require anyone other than the developer to review it. label Feb 7, 2020
@JoeRobich JoeRobich requested a review from sharwell February 7, 2020 01:05
@JoeRobich JoeRobich marked this pull request as ready for review February 7, 2020 01:05
@JoeRobich JoeRobich requested a review from a team as a code owner February 7, 2020 01:05
jasonmalinowski
jasonmalinowski approved these changes Feb 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it works, nice!

@jasonmalinowski
Copy link
Copy Markdown
Member

jasonmalinowski commented Feb 7, 2020

And indeed it does work:

Downloading https://raw.githubusercontent.com/dotnet/roslyn/master/eng/config/PublishData.json
Using VS Instance 1dd8ef0c (16.4.0 Preview 1.0) at "C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview"
Uninstalling old Roslyn VSIX

@JoeRobich JoeRobich merged commit 6ca4c50 into master Feb 7, 2020
@sharwell sharwell deleted the dev/jorobich/log-vs-version branch February 7, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@sharwell sharwell Awaiting requested review from sharwell

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoeRobich @jasonmalinowski @jaredpar