Skip to content

Remove unnecessary CS8717 suppressions.#41189

Merged
333fred merged 1 commit intodotnet:masterfrom
333fred:unnecessary-suppressions
Jan 24, 2020
Merged

Remove unnecessary CS8717 suppressions.#41189
333fred merged 1 commit intodotnet:masterfrom
333fred:unnecessary-suppressions

Conversation

@333fred
Copy link
Copy Markdown
Member

@333fred 333fred commented Jan 24, 2020

No description provided.

@333fred 333fred added Area-Compilers Concept-Null Annotations The issue involves annotating an API for nullable reference types labels Jan 24, 2020
@333fred 333fred requested review from a team and sharwell January 24, 2020 00:47
@333fred 333fred requested a review from a team as a code owner January 24, 2020 00:47
@jcouv jcouv self-assigned this Jan 24, 2020
jcouv
jcouv approved these changes Jan 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@333fred 333fred merged commit 698ad55 into dotnet:master Jan 24, 2020
@333fred 333fred deleted the unnecessary-suppressions branch January 24, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@jcouv jcouv jcouv approved these changes

+2 more reviewers

@sharwell sharwell sharwell approved these changes

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jcouv jcouv

Labels

Area-Compilers Concept-Null Annotations The issue involves annotating an API for nullable reference types

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@333fred @jasonmalinowski @sharwell @RikkiGibson @cston @jcouv