Fix document rename when case is same#41181
Merged
ryzngard merged 1 commit intodotnet:masterfrom Jan 24, 2020
Merged
Conversation
When renaming a document, we ensure that the name is unique but include the old document name in the check. Since that's the document that's name is changing, we can ignore it when comparing names for uniqueness.
ryzngard
commented
Jan 23, 2020
|
|
||
| <WpfFact> | ||
| <Trait(Traits.Feature, Traits.Features.Rename)> | ||
| Public Sub VerifyFileRenamesCorrectlyWhenCaseChanges() |
Contributor
Author
There was a problem hiding this comment.
Note that this doesn't actually validate the fix needed in this change, but I believe is a worthwhile test so I kept it.
jasonmalinowski
approved these changes
Jan 23, 2020
|
|
||
| VisualStudio.Editor.SendKeys(VirtualKey.Home, VirtualKey.Delete, VirtualKey.P, VirtualKey.Enter); | ||
|
|
||
| VisualStudio.SolutionExplorer.Verify.FileContents(project, "program.cs", |
Member
There was a problem hiding this comment.
Does the Verify.FileContents fail if the program.cs wasn't renamed at all and the file on disk is still called Program.cs?
Contributor
Author
There was a problem hiding this comment.
Hmmm.... I was really hoping it would check the file name matches case but it doesn't... It does verify that it's not called "Program1.cs" though =/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When renaming a document, we ensure that the name is unique
but include the old document name in the check. Since that's
the document that's name is changing, we can ignore it
when comparing names for uniqueness.
Fixes #39617