Support ExcludeFromCodeCoverageAttribute in local functions#41129
Merged
RikkiGibson merged 4 commits intodotnet:features/local-function-attributesfrom Jan 23, 2020
Merged
Conversation
cston
reviewed
Jan 22, 2020
src/Compilers/CSharp/Portable/Lowering/SyntheticBoundNodeFactory.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Jan 22, 2020
src/Compilers/CSharp/Portable/Lowering/Instrumentation/DynamicAnalysisInjector.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Jan 22, 2020
AlekseyTs
reviewed
Jan 22, 2020
src/Compilers/CSharp/Portable/Lowering/Instrumentation/DynamicAnalysisInjector.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jan 22, 2020
src/Compilers/CSharp/Portable/Lowering/SyntheticBoundNodeFactory.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jan 22, 2020
src/Compilers/CSharp/Portable/Lowering/SyntheticBoundNodeFactory.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jan 22, 2020
src/Compilers/CSharp/Portable/Lowering/Instrumentation/DynamicAnalysisInjector.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jan 22, 2020
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Done with review pass (iteration 2) #Resolved |
AlekseyTs
reviewed
Jan 23, 2020
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jan 23, 2020
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jan 23, 2020
src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter.cs
Outdated
Show resolved
Hide resolved
Contributor
|
Done with review pass (iteration 3) |
54 tasks
RikkiGibson
commented
Jan 23, 2020
| return RemoveDynamicAnalysisInjectors(previous); | ||
| case DebugInfoInjector { Previous: var previous } injector: | ||
| var newPrevious = RemoveDynamicAnalysisInjectors(previous); | ||
| return (object)newPrevious != previous ? new DebugInfoInjector(newPrevious) : injector; |
Member
Author
There was a problem hiding this comment.
We missed that the DebugInfoInjector singleton could be used in the case where newPrevious is the NoOp instrumenter. Will correct in a future PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #38801