Merged
Conversation
fe44e1c to
e57df48
Compare
I left space for us to declare multiple closure environments in a single scope, but that seems like overengineering at the moment and it makes a lot of code more complicated. We can always add it back if it seems like it would be worth it
e57df48 to
bcea8a8
Compare
cston
reviewed
Jan 21, 2020
src/Compilers/CSharp/Portable/Lowering/LambdaRewriter/LambdaRewriter.Analysis.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Jan 21, 2020
src/Compilers/CSharp/Portable/Lowering/LambdaRewriter/LambdaRewriter.Analysis.Tree.cs
Outdated
Show resolved
Hide resolved
cston
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves an ArrayBuilder for DeclaredEnvironments to a single environment.
This means that a scope only declares a single closure environment for its
captured variables.
I left space for us to declare multiple closure environments
in a single scope, but that seems like overengineering at the
moment and it makes a lot of code more complicated. We can
always add it back if it seems like it would be worth it