Skip to content

Delete server side liveshare handlers.#40998

Merged
dibarbet merged 6 commits intodotnet:masterfrom
dibarbet:delete_server_handlers
Jan 24, 2020
Merged

Delete server side liveshare handlers.#40998
dibarbet merged 6 commits intodotnet:masterfrom
dibarbet:delete_server_handlers

Conversation

@dibarbet
Copy link
Copy Markdown
Member

Delete the serverside handlers for liveshare requests that were migrated to ILanguageClient.

Typescript handlers were slightly refactored + merged into one location.

@dibarbet dibarbet added this to the 16.5.P3 milestone Jan 16, 2020
@dibarbet dibarbet requested a review from a team as a code owner January 16, 2020 01:01
Copy link
Copy Markdown
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine but I trust we're going to test every feature and every TypeScript feature to make sure everything is still works. This type of PR by nature is hard to catch bugs in during a code review simply because of all the code moving around.

Comment thread src/VisualStudio/LiveShare/Impl/LoadHandler.cs
Comment thread src/VisualStudio/LiveShare/Impl/Shims/TypeScriptHandlerShims.cs
Comment thread src/VisualStudio/LiveShare/Impl/Shims/TypeScriptHandlerShims.cs Outdated
@dibarbet dibarbet closed this Jan 22, 2020
@dibarbet dibarbet reopened this Jan 22, 2020
@dibarbet dibarbet merged commit d19b943 into dotnet:master Jan 24, 2020
@dibarbet dibarbet deleted the delete_server_handlers branch January 24, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants