Obsolete non-.editorconfig 'simplification options'. #40544
Merged
sharwell merged 10 commits intodotnet:masterfrom Jan 4, 2020
Merged
Obsolete non-.editorconfig 'simplification options'. #40544sharwell merged 10 commits intodotnet:masterfrom
sharwell merged 10 commits intodotnet:masterfrom
Conversation
Contributor
Author
|
@sharwell thoughts on this? |
sharwell
approved these changes
Jan 3, 2020
sharwell
reviewed
Jan 3, 2020
sharwell
approved these changes
Jan 3, 2020
Contributor
Author
|
@sharwell This is ready to go in. Thanks! :) |
Contributor
|
@jasonmalinowski to confirm that this should not be blocked on design review |
Contributor
Author
|
Thanks! |
| ' Failfast Conditions | ||
| If Not optionSet.GetOption(SimplificationOptions.PreferImplicitTypeInLocalDeclaration) OrElse | ||
| variableDeclarator.AsClause Is Nothing OrElse | ||
| Not variableDeclarator.Parent.IsKind( |
Contributor
There was a problem hiding this comment.
These options were available to users - they're on the publicly shipped API. I was using this to workaround #43123 so I guess now's a good time to fix that. I'll open a PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #40535. That should go in first.
These options are not actually controllable by the user. They add extra complexity in the simplification codepaths that we can remove.
It looks like at some point we received issues about bad simplification behavior. So we changed it, but added some options at the same time (perhaps in case we wanted to flip the behavior). However, these are not actually controllable in any meaningful way by the user, or exposed through our .editorconfig system. So they effectively encode legacy concerns that we don't need to keep around.