Skip to content

Add helper methods for the Binder to assert that we are not recording used assemblies while binding for SemanticModel.#40178

Merged
AlekseyTs merged 1 commit intodotnet:features/UsedAssemblyReferencesfrom
AlekseyTs:UsedAssemblies_04
Dec 6, 2019
Merged

Add helper methods for the Binder to assert that we are not recording used assemblies while binding for SemanticModel.#40178
AlekseyTs merged 1 commit intodotnet:features/UsedAssemblyReferencesfrom
AlekseyTs:UsedAssemblies_04

Conversation

@AlekseyTs
Copy link
Copy Markdown
Contributor

No description provided.

… used assemblies while binding for SemanticModel.
@AlekseyTs AlekseyTs requested review from a team and 333fred December 5, 2019 22:00
return result;
}

internal void AddUsedAssembly(AssemblySymbol assembly)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal [](start = 8, length = 8)

private?

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Dec 5, 2019
Copy link
Copy Markdown
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekseyTs AlekseyTs merged commit 0f03fa5 into dotnet:features/UsedAssemblyReferences Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants