Skip to content

Convert operand expressions in an error case#40093

Merged
gafter merged 3 commits intodotnet:masterfrom
gafter:master-39975
Dec 4, 2019
Merged

Convert operand expressions in an error case#40093
gafter merged 3 commits intodotnet:masterfrom
gafter:master-39975

Conversation

@gafter
Copy link
Copy Markdown
Member

@gafter gafter commented Dec 2, 2019

Fixes #39975

@gafter gafter added this to the 16.5 milestone Dec 2, 2019
@gafter gafter requested review from a team and AlekseyTs December 2, 2019 23:32
@gafter gafter self-assigned this Dec 2, 2019
@cston
Copy link
Copy Markdown
Contributor

cston commented Dec 2, 2019

            return new BoundCompoundAssignmentOperator(node, BinaryOperatorSignature.Error, left, right,

Do we need to use BindToTypeForErrorRecovery() here as well? #Resolved


Refers to: src/Compilers/CSharp/Portable/Binder/Binder_Operators.cs:95 in 04a83de. [](commit_id = 04a83de, deletion_comment = False)

@gafter
Copy link
Copy Markdown
Member Author

gafter commented Dec 3, 2019

@AlekseyTs Can you review this please?

Copy link
Copy Markdown
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 3)

@gafter gafter merged commit e0404c0 into dotnet:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants