Skip to content

Diagnostics refactoring#40078

Merged
tmat merged 6 commits intodotnet:masterfrom
tmat:Workspace
Dec 4, 2019
Merged

Diagnostics refactoring#40078
tmat merged 6 commits intodotnet:masterfrom
tmat:Workspace

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Dec 1, 2019

Add nullable annotations.
Remove dependency on Workspace from IBuiltInAnalyzer.OpenFileOnly.
Remove usages of Solution.Workspace from DiagnosticIncrementalAnalyzer.
Clean up DiagnosticData factories.

@tmat tmat changed the title Refactoring Diagnostics refactoring Dec 2, 2019
@tmat tmat marked this pull request as ready for review December 2, 2019 22:40
@tmat tmat requested review from a team as code owners December 2, 2019 22:40
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Dec 2, 2019

@dotnet/roslyn-ide PTAL

Comment thread src/Workspaces/Core/Portable/CodeFixes/CodeFix.cs
Comment thread src/Workspaces/Core/Portable/Utilities/IDictionaryExtensions.cs
Comment thread src/Features/Core/Portable/Diagnostics/DiagnosticResultSerializer.cs Outdated
Comment thread src/Workspaces/Core/Portable/Diagnostics/DiagnosticData.cs Outdated
Comment thread src/Workspaces/Core/Portable/Diagnostics/DiagnosticDataSerializer.cs Outdated
@tmat tmat requested a review from a team December 3, 2019 21:56
@tmat tmat merged commit 24f084d into dotnet:master Dec 4, 2019
@tmat tmat deleted the Workspace branch December 4, 2019 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants