Skip to content

Switch source writer entirely over to using interpolations.#39281

Merged
RikkiGibson merged 12 commits intodotnet:masterfrom
CyrusNajmabadi:interpolations
Oct 15, 2019
Merged

Switch source writer entirely over to using interpolations.#39281
RikkiGibson merged 12 commits intodotnet:masterfrom
CyrusNajmabadi:interpolations

Conversation

@CyrusNajmabadi
Copy link
Contributor

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner October 15, 2019 01:19
@CyrusNajmabadi
Copy link
Contributor Author

Tagging @333fred @jcouv

@sharwell sharwell added Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 15, 2019
@jcouv jcouv self-assigned this Oct 15, 2019
@jcouv jcouv added this to the 16.4.P3 milestone Oct 15, 2019
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! (iteration 12)

@CyrusNajmabadi
Copy link
Contributor Author

@jcouv Thanks. As this makes no changes to actually any emitted source, do you think we can get this merged in soon?

@CyrusNajmabadi
Copy link
Contributor Author

@333fred want to take a look? fairly minimal change.

@RikkiGibson RikkiGibson self-requested a review October 15, 2019 18:52
Copy link
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RikkiGibson RikkiGibson merged commit 521697f into dotnet:master Oct 15, 2019
@CyrusNajmabadi
Copy link
Contributor Author

Thanks!

@CyrusNajmabadi CyrusNajmabadi deleted the interpolations branch October 15, 2019 19:22
@CyrusNajmabadi CyrusNajmabadi restored the interpolations branch October 28, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants