Fix IDE0009 false positive on local functions#39228
Merged
allisonchou merged 5 commits intodotnet:masterfrom Oct 15, 2019
Merged
Fix IDE0009 false positive on local functions#39228allisonchou merged 5 commits intodotnet:masterfrom
allisonchou merged 5 commits intodotnet:masterfrom
Conversation
mavasani
reviewed
Oct 10, 2019
src/Features/Core/Portable/QualifyMemberAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Oct 10, 2019
src/Features/Core/Portable/QualifyMemberAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
Show resolved
Hide resolved
RikkiGibson
reviewed
Oct 11, 2019
src/Features/Core/Portable/QualifyMemberAccess/AbstractQualifyMemberAccessDiagnosticAnalyzer.cs
Outdated
Show resolved
Hide resolved
mavasani
approved these changes
Oct 11, 2019
sharwell
approved these changes
Oct 11, 2019
Contributor
|
This is similar to how DotNetAnalyzers/StyleCopAnalyzers#3023 is resolved, and goes back to a change in the meaning of |
| case IInvocationOperation invocationOperation: | ||
| return invocationOperation.TargetMethod == null || invocationOperation.TargetMethod.IsStatic; | ||
| return invocationOperation.TargetMethod == null || invocationOperation.TargetMethod.IsStatic || | ||
| invocationOperation.TargetMethod is IMethodSymbol { MethodKind: MethodKind.LocalFunction }; |
Contributor
There was a problem hiding this comment.
can we extract a helper that boty of these codepaths should call?
| } | ||
|
|
||
| private bool IsStaticMemberOrTargetMethod(IOperation operation) | ||
| private bool IsMemberOrTargetMethodStaticOrLocalFunction(IOperation operation) |
Contributor
There was a problem hiding this comment.
Feels like a better name would be IsStaticMemberOrIsLocalFunction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38043 and adds relevant test.